Qbasicnews.com

QbasicNews.Com => Site/Forum Issues => Topic started by: Z!re on September 22, 2004, 09:09:18 AM



Title: Topic titles missing
Post by: Z!re on September 22, 2004, 09:09:18 AM
(http://quickhost.qbtk.com/download.php?id=210)

Has happened before, 1-2 times, after the tooltip mod was installed.
Never before.


There is no topic title, not even a space, to enter one has to click the "last post" button.




(The red jagged thingy, is just an edit, the image was 1280 wide before.=


Title: Topic titles missing
Post by: KiZ on September 22, 2004, 09:24:18 AM
hmm.


*turns tooltip mod on*

*switches to subSilver*

The topic in question appears fine for me. Strange...

What browser, and does it reoccour when you refresh?


Title: Topic titles missing
Post by: Z!re on September 22, 2004, 09:31:18 AM
IE, it's only every other time, always a different topic.

And like I said, this is only the third time since the mod was installed, that I've seen it.

Seems to only happen every once in a while, and goes away after i post in any topic in the same forum.


Title: Topic titles missing
Post by: Fling-master on September 22, 2004, 11:12:37 AM
Interesting... I noticed that exact same problem (actually it was the same topic too heh).

Oracle? ;)

EDIT: Oh yeah... tooltips are on for me and I'm using that dark skin (can't remember the name offhand... ahh smartDark... that's it)


Title: Topic titles missing
Post by: HQSneaker on September 22, 2004, 11:44:07 AM
Never had any problems. I use smartDark as well, tooltip mod on. And yes, I vist regularely.


Title: Topic titles missing
Post by: KiZ on September 22, 2004, 11:51:48 AM
Browsers, people, which browsers are ya using?

I get no probs with FF. Z!re was using IE

Maybe this is the problem?


Title: Topic titles missing
Post by: HQSneaker on September 22, 2004, 11:57:47 AM
FF


Title: Topic titles missing
Post by: Ruudboy on September 22, 2004, 12:01:45 PM
i use IE and i ain't got no probs, stupid IE, not even microsofts program


Title: Topic titles missing
Post by: TheBigBasicQ on September 22, 2004, 12:20:17 PM
i too havent gotten any problems and the tooltip mod is on =).


Title: Topic titles missing
Post by: wildcard on September 22, 2004, 01:28:50 PM
It seems to be an IE issue. But regardless if it happens to you can you post your browser and browser version so we can test it further.


Title: Topic titles missing
Post by: Z!re on September 22, 2004, 02:11:44 PM
IE 6.0

It only happens once in a while...


Title: Topic titles missing
Post by: Fling-master on September 22, 2004, 02:34:56 PM
HTML for the topic who's title is (still) missing

Code:
<tr>
 <td class="row1" align="center" valign="middle" width="20"><img src="templates/smartDark/images/folder.gif" width="19" height="18" alt="No new posts" title="No new posts" /></td>
 <td class="row1" width="100%"><span class="topictitle"><a href="viewtopic.php?t=6861" class="topictitle" title="edit:still, I made copy-paste...and qb said:"END SUB or END ">How to make textbox?</a></span><span class="gensmall"><br />
</span></td>
 <td class="row2" align="center" valign="middle"><span class="postdetails">9</span></td>
 <td class="row3" align="center" valign="middle"><span class="name"><a href="profile.php?mode=viewprofile&amp;u=1233">-dezell-</a></span></td>
 <td class="row2" align="center" valign="middle"><span class="postdetails">99</span></td>
 <td class="row3Right" align="center" valign="middle" nowrap="nowrap"><span class="postdetails">21 Sep 2004 04:05<br /><a href="profile.php?mode=viewprofile&amp;u=1233">-dezell-</a> <a href="viewtopic.php?p=78224#78224"><img src="templates/smartDark/images/icon_latest_reply.gif" alt="View latest post" title="View latest post" border="0" /></a></span></td>
</tr>


Note the ... title="edit:still, I made copy-paste...and qb said:"END SUB or END "> ... part.

;)


Title: Topic titles missing
Post by: wildcard on September 22, 2004, 04:25:26 PM
Its an IE error, and its something to do with the : being next to the t. With a space in between it shows up fine. So I'm not sure why that causes a problem..

For comparsion, the only difference between IE showing the topic and it not is a space. Anyone know why?

Doesn't work in IE

Quote

<td class="row1" width="100%"><span class="topictitle"><a href="viewtopic.php?t=6861" class="topictitle" title="edit:still, I made copy-paste...and qb said:"END SUB or END ">How to make textbox?</a></span><span class="gensmall"><br />
      </span></td>


Works in IE:

Quote

<td class="row1" width="100%"><span class="topictitle"><a href="viewtopic.php?t=6861" class="topictitle" title="edit :still, I made copy-paste...and qb said:"END SUB or END">How to make textbox?</a></span><span class="gensmall"><br />
      </span></td>


Firefox displays both versions.


Title: Topic titles missing
Post by: Fling-master on September 22, 2004, 04:57:56 PM
Actually I thought it had something to do with the extra quote in there. Guess not lol. No idea why the colon would be messing it up though.


Title: Topic titles missing
Post by: wildcard on September 22, 2004, 05:14:12 PM
You are right, it is the quote. I just did some more testing. The colon is just a coincidence. It seems like its just the way the title text is parsed is different.


Title: Topic titles missing
Post by: KiZ on September 23, 2004, 06:15:16 AM
Ok, so the problem is when one of the tool tips encloses a quote mark. Wildcard, you could use php to strip the variable (used in the tool tip) of quotation marks, and see if the halts the problem.


Title: Topic titles missing
Post by: TheBigBasicQ on September 23, 2004, 08:32:12 AM
Quote from: "wildcard"
Its an IE error, and its something to do with the : being next to the t. With a space in between it shows up fine. So I'm not sure why that causes a problem..

For comparsion, the only difference between IE showing the topic and it not is a space. Anyone know why?

Doesn't work in IE


Take a *wild* guess :D (no pun intended)

Quote from: "wildcard"
Firefox displays both versions.


hmm...i'll be damned =P.


Title: Topic titles missing
Post by: wildcard on September 23, 2004, 01:34:10 PM
Actually I'm not sure if its an IE error as such, more like just the parsing being a bit more strict. I'm not sure how FireFox parses it and IE doesn't.

dark: I'll add that in asap.


Title: Topic titles missing
Post by: Zap on September 23, 2004, 01:51:12 PM
change them to

Code:
&quot;


that should make them show up.


Title: Topic titles missing
Post by: wildcard on September 23, 2004, 03:40:54 PM
Ok I've done a "fix", it doesn't seem to be a problem in either browsers(Firefox/IE). Let me know if its working now or if I just managed to move the bug/problem elsewhere ;-)


Title: Topic titles missing
Post by: oracle on September 23, 2004, 08:48:03 PM
Aah crap... there's always something I'm forgetting... :lol:

wc: I take it you just ran the title text through htmlentities, right?


Title: Topic titles missing
Post by: wildcard on September 24, 2004, 03:58:35 AM
No I simply did a replace of quote to the html equvialent.


Title: Topic titles missing
Post by: oracle on September 24, 2004, 08:27:57 PM
OK. When I get around to doing the javascript version, I'll add it in :)


Title: Topic titles missing
Post by: KiZ on September 25, 2004, 09:15:30 AM
you know, when adding things like that, without placing a htmlentites or similar, it is very easy to write exploits, for example, if I had known about that bug before hand, i could have forwarded the entire General forum to a complete new site ;)  You have to be careful about security loop holes.

Whitetiger showed me the importance of that a while ago.


Title: Topic titles missing
Post by: wildcard on September 25, 2004, 02:23:44 PM
dark: There shouldn't have been any loophole/bug as html is turned off generally on the forum here. But I've used htmlentities now anyway ;-) Either way if theres probs let us know.


Title: Topic titles missing
Post by: KiZ on September 26, 2004, 07:24:49 AM
html may be turned off in the posts, but can it not still be run from a tooltip, like that? I mean if you hadnt put in the fix, would this not work:

if i started the post with:

">Hijacked Thread name here</a>

surely that would actually work, no?


Title: Topic titles missing
Post by: Zap on September 26, 2004, 07:33:35 AM
as soon as you post that text, it gets run thru the php function htmlentities, which makes " to &quot; < to &lt; aso, therefore the browser interprets them as stuff to print on screen, and not anything to parse.


Title: Topic titles missing
Post by: KiZ on September 26, 2004, 12:02:25 PM
oh, so you mean it gets stored after htmlentites is run? Right.. that works i guess =) I was under the impression that html entities was run as the page was processed, which would explain why the quote mark made a mess of the tooltip, because wildcard might have forgotten to put Htmlentites for the tooltip.


Title: Topic titles missing
Post by: wildcard on September 26, 2004, 02:49:14 PM
Not knowing phpBB/php very well I assume that the way phpBB checks/changes html to text doesn't include quotes, it may use html enities and leave quotes, I'm not sure.


Title: Topic titles missing
Post by: KiZ on September 27, 2004, 10:29:12 AM
Quote from: "wildcard"
Not knowing phpBB/php very well I assume that the way phpBB checks/changes html to text doesn't include quotes, it may use html enities and leave quotes, I'm not sure.


That would explain the whole thing then. ok dokes!


Title: Topic titles missing
Post by: oracle on September 27, 2004, 07:16:07 PM
Quote from: "dark_prevail"
html may be turned off in the posts, but can it not still be run from a tooltip, like that? I mean if you hadnt put in the fix, would this not work:

if i started the post with:

">Hijacked Thread name here</a>

surely that would actually work, no?


Possibly it might have worked - the text in the database is stored "as is" except for adding IDs to bbcodes that will be translated (that's why you might se [b:38c93fd910] or something similar sometimes). I may have forgotten to translate the characters coming out of the db and into the title though.

Oh, and for some reason phpBB seems to use htmlspecialchars a lot...